Skip to content

Replacing deprecated Std.is with Std.isOfType #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kuremu wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Replacing deprecated Std.is with Std.isOfType #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/mloader/HttpLoader.hx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,19 +154,19 @@ class HttpLoader<T> extends LoaderBase<T>
// default content type
var contentType = "application/octet-stream";

if (Std.is(data, Xml))
if (Std.isOfType(data, Xml))
{
// convert to string and send as application/xml
data = Std.string(data);
contentType = "application/xml";
}
else if (!Std.is(data, String))
else if (!Std.isOfType(data, String))
{
// stringify and send as application/json
data = haxe.Json.stringify(data);
contentType = "application/json";
}
else if (Std.is(data, String) && validateJSONdata(data))
else if (Std.isOfType(data, String) && validateJSONdata(data))
{
//data is already a valid JSON string
contentType = "application/json";
Expand Down
4 changes: 2 additions & 2 deletions test/mloader/XmlLoaderTest.hx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ class XmlLoaderTest
loader.load();

Assert.isTrue(Type.enumEq(events[0].type, Complete));
Assert.isTrue(Std.is(loader.content, Xml));
Assert.isTrue(Std.isOfType(loader.content, Xml));
Assert.areEqual(xml.toString(), loader.content.toString());
}

Expand All @@ -98,7 +98,7 @@ class XmlLoaderTest


Assert.isTrue(Type.enumEq(events[0].type, Complete));
Assert.isTrue(Std.is(loader.content, Xml));
Assert.isTrue(Std.isOfType(loader.content, Xml));
Assert.areEqual(xml.firstChild().toString(), loader.content.toString());
}

Expand Down