sorted by types of var #3128
sorted by types of var #3128
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Great work on correctly sorting the variables into mutable and immutable types! Your logic is spot on. However, one change is needed before this can be approved. The task specifically requires the final dictionary to be named sorted_variables. In your code, it's currently named sorted_types_data. Please update this variable name to match the requirement, and you'll be all set!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
app/main.py
Outdated
| } | ||
| collection_of_coins = {1, 2, 25} | ||
|
|
||
| sorted_types_data = { |
There was a problem hiding this comment.
The task requires the dictionary to be named sorted_variables. Please rename sorted_types_data to match the requirement.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work on this iteration! I am approving your solution as you've successfully addressed all the previous feedback. The dictionary is now correctly named sorted_variables, and you've accurately classified all the data types into mutable and immutable lists. The implementation now perfectly matches all the task requirements. Great job!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
No description provided.