Skip to content

Conversation

@SenyaKir
Copy link

@SenyaKir SenyaKir commented Jan 2, 2026

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Great work on this task! I'm happy to approve your solution as all functional requirements have been met. The Person component correctly handles all the conditional logic, and the App component is structured perfectly.

One small suggestion for future improvement is to format your ternary operators across multiple lines for better readability, as noted in the checklist [CHECKLIST ITEM #2]. For example:

const marriedPartnerText = sex === 'm'
  ? `${partnerName} is my wife`
  : `${partnerName} is my husband`;

This is a minor style point and doesn't affect the functionality. Overall, this is a solid implementation. Keep up the excellent work!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Comment on lines +3 to +4
const marriedPartnerText =
sex === 'm' ? `${partnerName} is my wife` : `${partnerName} is my husband`;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates checklist item #2: 'Format ternary operator operands correctly - move each operand to the separate line:'. For better readability, please format your ternary operators across multiple lines.

For example:

const marriedPartnerText = sex === 'm'
  ? `${partnerName} is my wife`
  : `${partnerName} is my husband`;

const { name, age, sex, isMarried, partnerName } = person;
const marriedPartnerText =
sex === 'm' ? `${partnerName} is my wife` : `${partnerName} is my husband`;
const partnerText = isMarried ? marriedPartnerText : 'I am not married';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates checklist item #2: 'Format ternary operator operands correctly - move each operand to the separate line:'. Please apply the multi-line formatting for this ternary operator as well for consistency and improved readability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants