-
Notifications
You must be signed in to change notification settings - Fork 1.4k
ask #1237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
ask #1237
Conversation
FaiHamid
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
Let`s just fix a few details:
src/App.tsx
Outdated
| Clear completed | ||
| </button> | ||
| </footer> | ||
| {/* Hide the footer if there are no todos */} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove unnecassery comments.
| type ContextType = { | ||
| state: Todo[]; | ||
| dispatch: React.Dispatch<Action>; | ||
| setFilter: (filter: 'all' | 'active' | 'completed') => void; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Create enum for filters.
vitalii-bondarenko-ua
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
https://iirk1.github.io/react_todo-app/