Conversation
…conclusively modified enriched_cat.v (the version I'm working on)
CohenCyril
reviewed
Jun 22, 2023
tests/enriched_cat.v
Outdated
| Fail Record Monoid_enriched_quiverN1 := { | ||
| ObjN: Type; | ||
| iQ: isQuiver ObjN; | ||
| hsM: forall A B, hom_isM_ty (@hom iQ) |
Member
There was a problem hiding this comment.
This fails because hom expects a Quiver.type not a isQuiver. You can try to use HB.pack here.
Member
There was a problem hiding this comment.
…hed_cat.v compiles
CohenCyril
reviewed
Jul 5, 2023
Comment on lines
+147
to
+148
| HB.instance Definition funQ_isMon (A B: Type) : isMon (hom A B) := | ||
| funQ_isMonF A B. |
Member
There was a problem hiding this comment.
One thing we missed here was that this instance should not be created.
We should replace by an instance of the wrapper mixin.
Indeed the wrapper mixin projection private has already been declared as an instance of isMon on hom.
CohenCyril
reviewed
Jul 5, 2023
Co-authored-by: Cyril Cohen <CohenCyril@users.noreply.github.com>
Member
|
@ptorrx I recommend never merging in a PR, but only rebasing. |
…reaks the compilation of the Coq code. Included call to derive-wrapper-instances in declare-all, but not really sure about it. Commented out funQ_isMon in monoid_enriched_cat.v because it should be derivable, once funQ_hom_isMon is available. But actually I can't see where HB learns about funQ_isMonF, except in the funQ_hom_isMon definition (the one we should actually generate)
…s in instance.elpi, funQ_isMon back in
…s in instance.elpi, funQ_isMon back in
…plicates in the association list (which was broken in DCIFF with std.forall)
… to declare-instance
…instance, not working yet
…instance, now working
…tory-based example in monoid_enriched_cat_factory.v
…ompilation glitch (it will compile only the first two of them, regardless of which you put first; so all the examples compile, but not together)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.