Add warning about implicitly local HB.instance calls, improve error messages#561
Open
lweqx wants to merge 3 commits intomath-comp:masterfrom
Open
Add warning about implicitly local HB.instance calls, improve error messages#561lweqx wants to merge 3 commits intomath-comp:masterfrom
HB.instance calls, improve error messages#561lweqx wants to merge 3 commits intomath-comp:masterfrom
Conversation
HB.instance calls, improve errors messagesHB.instance calls, improve error messages
CohenCyril
reviewed
Oct 16, 2025
Member
|
I'm also having second thoughts on whether to fail or warn on noop HB.end. indeed it is practical to be able to close a section without obstruction, in order to be able to evaluate further down in the file, an it is even more crucial when using Rocq lsp continuous mode since the rest of the file will be interpreted in the HB.builder context (despite the presence of HB.end) ... |
65596c4 to
a435ffe
Compare
Author
|
I think it should only be a warning mainly because writing code that does nothing is not an error. I don't think it really matters though. Happy to change it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For more context, see the corresponding topic on Zulip.
Demo: