Replace old lodash with more modern lodash-es

app/app.js

@@ -3,7 +3,7 @@ import Application from '@ember/application';
 import loadInitializers from 'ember-load-initializers';
 import Resolver from 'ember-resolver';
 import $ from 'jquery';
-import _ from 'lodash';
+import * as _ from 'lodash-es';
 import config from './config/environment';
 
 // export for others scripts to use

app/components/answer-new.js

@@ -1,7 +1,7 @@
 import ErrorHandlingComponent from './error-handling';
 import { tracked } from '@glimmer/tracking';
 import { action } from '@ember/object';
-import isEqual from 'lodash/isEqual';
+import isEqual from 'lodash-es/isEqual';
 import { service } from '@ember/service';
 import validate from 'validate.js';
 import $ from 'jquery';

app/components/bread-crumbs-item.js

@@ -1,9 +1,9 @@
 import Component from '@glimmer/component';
 import { action } from '@ember/object';
 import moment from 'moment';
-import isEqual from 'lodash/isEqual';
-import isString from 'lodash/isString';
-import isObject from 'lodash/isObject';
+import isEqual from 'lodash-es/isEqual';
+import isString from 'lodash-es/isString';
+import isObject from 'lodash-es/isObject';
 
 export default class BreadCumbsItemComponent extends Component {
   get isSelected() {

app/components/comment-list.js

@@ -13,11 +13,13 @@ import { computed } from '@ember/object';
  *   TODO:
  *   - Test the hashtag stuff to see if that is still working.
  */
-/*global _:false */
 import { and, equal } from '@ember/object/computed';
-import { inject as service } from '@ember/service';
+import { service } from '@ember/service';
 import $ from 'jquery';
 import moment from 'moment';
+import isArray from 'lodash-es/isArray';
+import isNaN from 'lodash-es/isNaN';
+import random from 'lodash-es/random';
 import ErrorHandlingMixin from '../mixins/error_handling_mixin';
 
 export default Component.extend(ErrorHandlingMixin, {
@@ -119,8 +121,8 @@ export default Component.extend(ErrorHandlingMixin, {
     let path = `labels.${newCommentLabel}.placeholder`;
     let placeholder = this.get(path);
 
-    if (_.isArray(placeholder)) {
-      placeholder = placeholder[_.random(0, placeholder.length - 1)];
+    if (isArray(placeholder)) {
+      placeholder = placeholder[random(0, placeholder.length - 1)];
     }
     return placeholder;
   }),
@@ -340,20 +342,20 @@ export default Component.extend(ErrorHandlingMixin, {
     }
     let month = split[0];
     let monthInt = parseInt(month, 10);
-    if (_.isNaN(monthInt) || monthInt > 12 || monthInt < 1) {
+    if (isNaN(monthInt) || monthInt > 12 || monthInt < 1) {
       return false;
     }
     let day = split[1];
     let dayInt = parseInt(day, 10);
 
-    if (_.isNaN(dayInt) || dayInt < 1 || dayInt > 31) {
+    if (isNaN(dayInt) || dayInt < 1 || dayInt > 31) {
       return false;
     }
 
     let year = split[2];
     let yearInt = parseInt(year, 10);
 
-    if (_.isNaN(yearInt) || yearInt < 1000 || yearInt > 9999) {
+    if (isNaN(yearInt) || yearInt < 1000 || yearInt > 9999) {
       return false;
     }
     return true;
@@ -599,7 +601,7 @@ export default Component.extend(ErrorHandlingMixin, {
         let dateInput = this.sinceDate;
         let parsedDate = Date.parse(dateInput);
 
-        if (_.isNaN(parsedDate)) {
+        if (isNaN(parsedDate)) {
           return this.set('invalidDateError', 'Please enter a valid date');
         }
         options.sinceDate = dateInput;

app/components/import-work-step1.js

@@ -1,7 +1,7 @@
 import Component from '@ember/component';
 import { computed } from '@ember/object';
-/*global _:false */
-import { inject as service } from '@ember/service';
+import isNull from 'lodash-es/isNull';
+import { service } from '@ember/service';
 
 export default Component.extend({
   elementId: 'import-work-step1',
@@ -21,7 +21,7 @@ export default Component.extend({
         return;
       }
 
-      const isRemoval = _.isNull($item);
+      const isRemoval = isNull($item);
       if (isRemoval) {
         this.set('selectedProblem', null);
         return;

app/components/import-work-step2.js

@@ -1,8 +1,8 @@
 import Component from '@ember/component';
 import { computed } from '@ember/object';
-/*global _:false */
 import { equal } from '@ember/object/computed';
-import { inject as service } from '@ember/service';
+import { service } from '@ember/service';
+import isNull from 'lodash-es/isNull';
 
 export default Component.extend({
   elementId: 'import-work-step2',
@@ -46,7 +46,7 @@ export default Component.extend({
         return;
       }
 
-      const isRemoval = _.isNull($item);
+      const isRemoval = isNull($item);
       if (isRemoval) {
         this.set('selectedSection', null);
         return;

app/components/import-work-step4.js

@@ -1,7 +1,7 @@
 import Component from '@ember/component';
 import { computed } from '@ember/object';
-/*global _:false */
-import { inject as service } from '@ember/service';
+import { service } from '@ember/service';
+import map from 'lodash-es/map';
 
 export default Component.extend({
   elementId: 'import-work-step4',
@@ -19,7 +19,7 @@ export default Component.extend({
     if (!this.studentMap) {
       return [];
     }
-    return _.map(this.studentMap, (val, key) => {
+    return map(this.studentMap, (val, key) => {
       return val;
     });
   }),

app/components/import-work-step5.js

@@ -1,8 +1,8 @@
 import Component from '@ember/component';
 import { computed } from '@ember/object';
 import { equal } from '@ember/object/computed';
-/*global _:false */
-import { inject as service } from '@ember/service';
+import { service } from '@ember/service';
+import isNull from 'lodash-es/isNull';
 
 export default Component.extend({
   elementId: 'import-work-step5',
@@ -132,7 +132,7 @@ export default Component.extend({
       this.set('createAssignmentValue', val);
     },
     updateSelectizeSingle(val, $item, propToUpdate, model) {
-      if (_.isNull($item)) {
+      if (isNull($item)) {
         this.set(propToUpdate, null);
         return;
       }

app/components/problem-info.js

@@ -1,8 +1,8 @@
 import Component from '@glimmer/component';
 import { tracked } from '@glimmer/tracking';
 import { action } from '@ember/object';
-import _isEqual from 'lodash/isEqual';
-import _isNull from 'lodash/isNull';
+import _isEqual from 'lodash-es/isEqual';
+import _isNull from 'lodash-es/isNull';
 import { service } from '@ember/service';
 
 export default class ProblemInfoComponent extends Component {

app/components/problem-new.js

@@ -2,7 +2,7 @@ import Component from '@glimmer/component';
 import { tracked } from '@glimmer/tracking';
 import { action } from '@ember/object';
 import { service } from '@ember/service';
-import _isNull from 'lodash/isNull';
+import _isNull from 'lodash-es/isNull';
 
 export default class ProblemNewComponent extends Component {
   @service('sweet-alert') alert;

app/components/search-bar.js

@@ -1,7 +1,7 @@
 import Component from '@ember/component';
 import { computed } from '@ember/object';
-/*global _:false */
 import { alias } from '@ember/object/computed';
+import debounce from 'lodash-es/debounce';
 import validate from 'validate.js';
 
 export default Component.extend({
@@ -23,10 +23,7 @@ export default Component.extend({
     let doDebounce = this.doDebounce || false;
     let debounceTime = this.debounceTime || 300;
     if (doDebounce) {
-      this.set(
-        'debouncedSearch',
-        _.debounce(this.onChangeSearch, debounceTime)
-      );
+      this.set('debouncedSearch', debounce(this.onChangeSearch, debounceTime));
     }
   },
 
@@ -99,17 +96,7 @@ export default Component.extend({
 
   actions: {
     clearResults: function () {
-      // let textVal = this.get("inputValue");
-      // let isString = _.isString(textVal);
-      // if (!isString) {
-      //   return;
-      // }
-      // let trimmed = textVal.trim();
-      // if (trimmed.length === 0) {
-      // just empty spaces, clear out search bar but dont bubble up and fetch
       this.set('inputValue', null);
-      // return;
-      // }
       this.clearSearchResults();
     },
 

app/components/submission-viewer-list.js

@@ -1,4 +1,3 @@
-/*global _:false */
 import Component from '@ember/component';
 import { computed } from '@ember/object';
 import $ from 'jquery';