WIP: fixes to make cellstotex to work #1104

mmatera · 2021-01-09T23:58:51Z

Tidier version of PR #995

mmatera · 2021-01-10T00:06:46Z

What is missing now to make this work is to complete the implementation of OptionValue and related symbols:
https://reference.wolfram.com/language/ref/OptionValue.html
This is important for this specific package, as well as many others

…athics into newcellstotexfixes2

fix OptionValue related small fix in documentation more fixes adding and fixing tests use get_option in OptionValue to deal with strings and context like in WMA fix return for non-atoms fixing OptionQ

improve support of symbol Function with a third argument fix attribute support in abstract functions clean

mmatera · 2021-01-25T22:33:06Z

Status update: Now all the structural issues in the mathics kernel seem to be solved, in a way that CellsToTeX loads properly and all the intricate WL idioms that this package uses for the conversion seem to be properly evaluated. Now, the next set of issues that are avoiding this particular library behaves like in WMA are related to Export functions (to PDF, to png, etc...). The next step is to fix them.

rocky · 2021-01-25T23:27:49Z

Status update: Now all the structural issues in the mathics kernel seem to be solved, in a way that CellsToTeX loads properly and all the intricate WL idioms that this package uses for the conversion seem to be properly evaluated. Now, the next set of issues that are avoiding this particular library behaves like in WMA are related to Export functions (to PDF, to png, etc...). The next step is to fix them.

When I follow the instructions at https://github.com/jkuczm/MathematicaCellsToTeX#no-installation , I get a number of failures in import:

In[1]:= Import@"https://raw.githubusercontent.com/jkuczm/MathematicaCellsToTeX/master/NoInstall.m"

Set::write: Tag FirstCase in FirstCase::usage is Protected.
Set::write: Tag Association in Association::usage is Protected.
Set::write: Tag AssociationQ in AssociationQ::usage is Protected.
Set::write: Tag Key in Key::usage is Protected.
Set::write: Tag Lookup in Lookup::usage is Protected.
Set::write: Tag Failure in Failure::usage is Protected.
Options::wrsym: Symbol FirstCase is Protected.
SetDelayed::write: Tag FirstCase in FirstCase[expr_, pattOrRule_, Shortest[default_ : Missing[NotFound], 1], Shortest[levelspec_ : {1}, 2], opts : OptionsPattern[]] is Protected.
SetDelayed::write: Tag FirstCase in FirstCase[pattOrRule_][expr_] is Protected.
SetDelayed::write: Tag Pattern in assoc_Association[key_] is Protected.
TagSetDelayed::tagnfd: Tag Association not found or too deep for an assigned rule.
TagSetDelayed::write: Tag Association in Append[Association[rules___], {newRules : (_Rule | _RuleDelayed)...} | (newRule : _Rule | _RuleDelayed)] is Protected.
Set::write: Tag AssociationQ in AssociationQ[Association[(_Rule | _RuleDelayed)...]] is Protected.
Set::write: Tag AssociationQ in AssociationQ[_] is Protected.
SetDelayed::write: Tag Lookup in Lookup[assoc_ ? AssociationQ, key_, default_] is Protected.
SetDelayed::write: Tag Lookup in Lookup[assoc_ ? AssociationQ, key_] is Protected.
Grid::optx: Alignment -> {Left, Top} is not a supported option for Grid[].
Grid::optx: Alignment -> {Left, Top} is not a supported option for Grid[].
TagSetDelayed::write: Tag Failure in MakeBoxes[Failure[tag_, assoc_Association], StandardForm] /; assoc[MessageTemplate] =!= Missing[KeyAbsent, MessageTemplate] && assoc[MessageParameters] =!= Missing[KeyAbsent, MessageParameters] && assoc[MessageParameters] =!= Missing[KeyAbsent, Type] is Protected.
Out[1]= {}

What's up here?

mmatera · 2021-01-25T23:55:38Z

Status update: Now all the structural issues in the mathics kernel seem to be solved, in a way that CellsToTeX loads properly and all the intricate WL idioms that this package uses for the conversion seem to be properly evaluated. Now, the next set of issues that are avoiding this particular library behaves like in WMA are related to Export functions (to PDF, to png, etc...). The next step is to fix them.

When I follow the instructions at https://github.com/jkuczm/MathematicaCellsToTeX#no-installation , I get a number of failures in import:

In[1]:= Import@"https://raw.githubusercontent.com/jkuczm/MathematicaCellsToTeX/master/NoInstall.m"

Set::write: Tag FirstCase in FirstCase::usage is Protected.
Set::write: Tag Association in Association::usage is Protected.
Set::write: Tag AssociationQ in AssociationQ::usage is Protected.
Set::write: Tag Key in Key::usage is Protected.
Set::write: Tag Lookup in Lookup::usage is Protected.
Set::write: Tag Failure in Failure::usage is Protected.
Options::wrsym: Symbol FirstCase is Protected.
SetDelayed::write: Tag FirstCase in FirstCase[expr_, pattOrRule_, Shortest[default_ : Missing[NotFound], 1], Shortest[levelspec_ : {1}, 2], opts : OptionsPattern[]] is Protected.
SetDelayed::write: Tag FirstCase in FirstCase[pattOrRule_][expr_] is Protected.
SetDelayed::write: Tag Pattern in assoc_Association[key_] is Protected.
TagSetDelayed::tagnfd: Tag Association not found or too deep for an assigned rule.
TagSetDelayed::write: Tag Association in Append[Association[rules___], {newRules : (_Rule | _RuleDelayed)...} | (newRule : _Rule | _RuleDelayed)] is Protected.
Set::write: Tag AssociationQ in AssociationQ[Association[(_Rule | _RuleDelayed)...]] is Protected.
Set::write: Tag AssociationQ in AssociationQ[_] is Protected.
SetDelayed::write: Tag Lookup in Lookup[assoc_ ? AssociationQ, key_, default_] is Protected.
SetDelayed::write: Tag Lookup in Lookup[assoc_ ? AssociationQ, key_] is Protected.
Grid::optx: Alignment -> {Left, Top} is not a supported option for Grid[].
Grid::optx: Alignment -> {Left, Top} is not a supported option for Grid[].
TagSetDelayed::write: Tag Failure in MakeBoxes[Failure[tag_, assoc_Association], StandardForm] /; assoc[MessageTemplate] =!= Missing[KeyAbsent, MessageTemplate] && assoc[MessageParameters] =!= Missing[KeyAbsent, MessageParameters] && assoc[MessageParameters] =!= Missing[KeyAbsent, Type] is Protected.
Out[1]= {}

What's up here?

This is an issue related to $VersionNumber. Depending on the version, CellsToTeX tryies to implement a set of Symbols that are available in WMA 10, but not in WMA <10. To avoid it, you need to execute
Unprotect[$VersionNumber];$VersionNumber=11;Protect[$VersionNumber];
before loading the package. This is already implemented in tests/test_cellstotex.py

rocky · 2021-01-26T16:29:25Z

I think that more than defining something inside the kernel, we just could have a folder with "proxies" to packages that needs this kind of workarounds. Also, this could be useful to list what packages are actually working, and at which level are working, at the time to let know to the authors of those packages how to make them compatible with mathics.

Sure - make it so!

Can we split off part of useful working parts of this PR like we did before? Thanks!

rocky · 2021-01-26T16:33:50Z

I think that more than defining something inside the kernel, we just could have a folder with "proxies" to packages that needs this kind of workarounds. Also, this could be useful to list what packages are actually working, and at which level are working, at the time to let know to the authors of those packages how to make them compatible with mathics.

Sure - make it so!

Can we split off part of useful working parts of this PR like we did before? Thanks!

mmatera · 2021-01-26T17:29:47Z

I think that more than defining something inside the kernel, we just could have a folder with "proxies" to packages that needs this kind of workarounds. Also, this could be useful to list what packages are actually working, and at which level are working, at the time to let know to the authors of those packages how to make them compatible with mathics.

Sure - make it so!

Can we split off part of useful working parts of this PR like we did before? Thanks!

Most of the improvements are already in PR # #1116. There are a few other changes I am working on splitting now as a new PR.

…ellstotexfixes2

rocky

@mmatera now that things have settled a bit, can we get this adjusted so we can merge it into master please?

Thanks.

rocky · 2021-03-04T14:22:30Z

test/test_cellstotex.py

    expr = parse(definitions, MathicsSingleLineFeeder(str_expression))
    return expr.evaluate(evaluation)

+_evaluate('LoadModule["pymathics.asy"]')


Hmmm... maybe it would be better to put this test in the pymathics repository instead of here.

If done here, we would have to have to check to see if pymathics.asy is installed.

The idea would be to download and load the module in the test. But first I need to complete the package and make it works...

If you do it in pymathics-asy then you don't have to download and everything is simpler.

Is there a reason not to do it there?

Yes, it could be there but is a little bit unrelated to that package. The idea of having this branch in mathics is not to actually merge it, but just to discover and collect several fixed required by the Mathics suit to load this package (and potentially, many others). Once this package (CellToTeX) pass the tests, we could put this test in a different repository, with the corresponding comments about how to actually make it run.

mmatera · 2021-03-31T01:58:17Z

superseded by #1215

fixes to make cellstotex to work

b0e63ed

mmatera added 25 commits January 9, 2021 21:47

adding options to ToString

9b9072e

Merge remote-tracking branch 'upstream/master' into newcellstotexfixes2

657a738

clean up

5441b9f

restoring tests

f10e3e0

merge options

b1ff26f

Merge branch 'fixnamedOptionsPattern' into newcellstotexfixes2

4a2f03e

fix optionpatterns with names

5ed9220

Merge branch 'fixnamedOptionsPattern' into newcellstotexfixes2

2a632b1

merge

b1d1b88

fix OptionValue related

997ed17

Merge branch 'fixnamedOptionsPattern' into newcellstotexfixes2

1d80bdc

adding and fixing tests

a02a129

Merge branch 'fixnamedOptionsPattern' of https://github.com/mathics/M…

d464c2f

…athics into newcellstotexfixes2

fixing OptionQ

b701894

(Stub) adding support for attributes in Function

34c7646

improve support of symbol Function with a third argument

bb8b78a

fix attribute support in abstract functions

15b993a

Improving support for OptionValue. Adding tests

39c9208

fix OptionValue related small fix in documentation more fixes adding and fixing tests use get_option in OptionValue to deal with strings and context like in WMA fix return for non-atoms fixing OptionQ

(Stub) adding support for attributes in Function

1aae381

improve support of symbol Function with a third argument fix attribute support in abstract functions clean

DRY option tests

ed75290

merge to master

00ee8a3

fix options

233f6c6

merge

b549ebb

improve Hash support

efe392b

improve Hash support

ec97564

GarkGarcia and others added 5 commits January 26, 2021 11:29

Added a PyYAML install in Makefile and .travis.yml

a19fdcc

Fixed typo

0860093

Removed references to PyYAML in CI

727078e

Revise for reworked mathics-scanner

472e0ed

DRY load modules. fix Hash and FileHash symbols

519e8ea

Merge branch 'master' of https://github.com/mathics/Mathics into newc…

117d6e3

…ellstotexfixes2

This was referenced Jan 26, 2021

improving support for Hash and FileHash functions #1133

Merged

WIP: improving support for import/export internals #1135

Merged

mmatera and others added 3 commits February 14, 2021 19:53

merge

7719b83

merge

d31c40e

Use MathicsSingleLineFeeder + lint changes

87e8d36

rocky reviewed Feb 21, 2021

View reviewed changes

mmatera added 6 commits February 21, 2021 16:24

Merge remote-tracking branch 'upstream/master' into newcellstotexfixes2

6f25908

clean up

0a26f3f

merge remote

9b69dd5

Merge remote-tracking branch 'upstream/master' into newcellstotexfixes2

af54884

Merge remote-tracking branch 'upstream/master' into newcellstotexfixes2

1b5178b

using asy for export

a9f6631

rocky reviewed Mar 4, 2021

View reviewed changes

merge

5a9782f

rocky force-pushed the master branch 2 times, most recently from 96ec58b to e8a5440 Compare March 14, 2021 13:55

rocky force-pushed the newcellstotexfixes2 branch from 5a9782f to 9b69dd5 Compare March 21, 2021 00:11

Merge remote-tracking branch 'upstream/master' into newcellstotexfixes2

e646493

mmatera mentioned this pull request Mar 31, 2021

Checks for CellsToTeX support #1215

Draft

mmatera closed this Mar 31, 2021

Uh oh!

WIP: fixes to make cellstotex to work #1104

WIP: fixes to make cellstotex to work #1104

Uh oh!

Conversation

mmatera commented Jan 9, 2021

Uh oh!

mmatera commented Jan 10, 2021

Uh oh!

mmatera commented Jan 25, 2021

Uh oh!

rocky commented Jan 25, 2021

Uh oh!

mmatera commented Jan 25, 2021

Uh oh!

rocky commented Jan 26, 2021

Uh oh!

rocky commented Jan 26, 2021

Uh oh!

mmatera commented Jan 26, 2021

Uh oh!

rocky left a comment

Choose a reason for hiding this comment

Uh oh!

rocky Mar 4, 2021

Choose a reason for hiding this comment

Uh oh!

mmatera Mar 4, 2021

Choose a reason for hiding this comment

Uh oh!

rocky Mar 4, 2021

Choose a reason for hiding this comment

Uh oh!

mmatera Mar 4, 2021

Choose a reason for hiding this comment

Uh oh!

mmatera commented Mar 31, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants