add /v2/balance/ endpoint; fix tests #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matiu
reviewed
Jan 26, 2021
| // * @param {Callback} cb | ||
| // */ | ||
| getBalance(opts, cb) { | ||
| getBalance(opts, cb, baseUrl) { |
Owner
There was a problem hiding this comment.
by default baseUrl should be the current URL (/v2/balance/ ? )
bsnowden3
force-pushed
the
feat/big-int-explore
branch
3 times, most recently
from
b3bf013 to
00f595d
Compare
matiu
reviewed
Jan 29, 2021
| err => { | ||
| should.not.exist(err,err); | ||
| balance.should.equal(1e8); | ||
| balance.toString().should.equal("100000000"); |
Owner
There was a problem hiding this comment.
the "toString()" here kind of defeat the purpose of the test. Maybe you can check that typeof balance is number?
bsnowden3
force-pushed
the
feat/big-int-explore
branch
from
00f595d to
c5f40b3
Compare
Mukulsam
approved these changes
Apr 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.