Brands renaming #8109
Brands renaming #8109
Conversation
…tector into BrandsRenaming
|
@liviuconcioiu @sanchezzzhak Does one of you have time to look through the brand renames in this PR? I unfortunately don't have time to validate them at the moment. |
|
@sgiehl since you resolved the comments about removal of short names, should I apply the same logic to other PRs from me? |
|
@Simbiat generally yes, but to avoid more merge conflicts it might be better to wait 🤔 |
|
|
||
| # TechSmart or Techmade | ||
| TechSmart: | ||
| # Techmade (often seen as TechSmart, which is actually a model line: https://www.ebay.it/itm/112931113112 https://www.ebay.it/itm/123071096677 https://www.facebook.com/661598300623815/photos/a.661606387289673/1242575672526072/?type=3&locale=hi_IN) |
There was a problem hiding this comment.
There was a problem hiding this comment.
I do not think it's the same one. Do not seem to create phones, and logo is different from what I was able to link to the devices https://github.com/Simbiat/DeviceDetectorIcons/blob/main/src/icons/device/brand/Techmade.webp
|
Resolved all comments from above besides Techmade, since I am not sure that's the same brand as on Techmade.eu |
|
So, what's stopping us from merge? I'd like to update the other PRs with similar logic for "removed" brands |
|
bump |
4 participants
Description:
Split from #8096 this covers brand name changes, that are mostly more than just addition of a prefix or otherwise more contentious
Review