fix highlight collapse in default themes#57
Open
uchijo wants to merge 1 commit intomattbierner:masterfrom
Open
fix highlight collapse in default themes#57uchijo wants to merge 1 commit intomattbierner:masterfrom
uchijo wants to merge 1 commit intomattbierner:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
what I did
when using this extension with default theme (dark+), the highlighting didn't work.
The reason was, it was referring to a resource file which does not exist, and it happens when this extension is used with default dark+ theme.
It seems to be implemented by branching whether theme name is dark+ or light+. So I removed this branch and let shiki do all the thing.
It seems it's caused by version change of shiki. by migrating from 0.2.5 to 0.14, the folder structure seems to be changed.
concerns
The comment says we need to handle default theme separately, because they use
includeoption, which shiki does not support.I looked the code carefully and I think it's okay to delete this special handling. But I'm not so confident.