Update docker-compose.yml: Increased pid_limit and added mem_limit #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Increased pid_limit to mattermost container which low value caused vary plugin crashes and unableing to use mmctl inside container - Added memory limitation to mattermost container for preventing potential memory leaks
hanzei
requested changes
Dec 17, 2024
Comment on lines
+34
to
+37
| pids_limit: 500 | ||
| mem_reservation: 2G | ||
| mem_limit: 8G | ||
| memswap_limit: 2G |
Contributor
There was a problem hiding this comment.
I don't think we should enforce these limits by default. I'm fine with documenting them in the README, but a default limit seems too much. There are cases where more than 8G are needed, e.g. for large servers.
hanzei
added
2: Dev Review
Contributor
|
/update-branch |
|
This PR has been automatically labelled "stale" because it hasn't had recent activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Commentary: In case of our mattermost server I can track by
systemd-cgtopcommand that mattermost container using over 200 tasks. This low value on pid_limit caused vary plugins crashing accidentially and failing container healthcheck. This issues was very hard to investigate. I only discover this when I was needed to usemmctland I was unable to run binary inside container with next error:Commentary: This limitations were added to our mattermost server after several memory leaks during last year. Before upgrading to 7.1.3 several leaks was caused by mention 100+ users over @ALL command in channel, but this already fixed afaik. Recent leak that was on latest LTS 7.1.3 relase we ain't determined but we guessing it caused by playbooks plugin beacause of a lot of errors on consumtion memory peak.
Hope this information can help someone.