Skip to content

backfill: fix check for bundled data containing all messages #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Fizzadar merged 1 commit into from
Jan 30, 2026
Merged

backfill: fix check for bundled data containing all messages #216

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions pkg/connector/backfill.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,17 @@ func (m *MetaClient) FetchMessages(ctx context.Context, params bridgev2.FetchMes
}
upsert, _ := params.BundledData.(*table.UpsertMessages)
if upsert == nil || len(upsert.Messages) < params.Count {
// Shortcut: bundled data min TS <= anchor TS, meaning we have everything
if params.Forward && params.BundledData != nil && params.AnchorMessage != nil {
anchorTS := params.AnchorMessage.Timestamp.UnixMilli()
if upsert.Range.MinTimestampMs <= anchorTS {
zerolog.Ctx(ctx).Debug().
Int64("bundled_min_ts", upsert.Range.MinTimestampMs).
Int64("anchor_ts", anchorTS).
Msg("Forward backfill has all messages already")
return m.wrapBackfillEvents(ctx, params.Portal, upsert, params.AnchorMessage, params.Forward), nil
}
}
var oldestMessageID string
var oldestMessageTS int64
if upsert != nil {
Expand Down Expand Up @@ -225,10 +236,6 @@ func (m *MetaClient) FetchMessages(ctx context.Context, params bridgev2.FetchMes
zerolog.Ctx(ctx).Warn().Msg("Can't backfill chat with no messages")
return nil, nil
}
if params.Forward && params.BundledData != nil && upsert.Range.MinTimestampMs >= oldestMessageTS {
zerolog.Ctx(ctx).Debug().Msg("Forward backfill has all messages already")
return m.wrapBackfillEvents(ctx, params.Portal, upsert, params.AnchorMessage, params.Forward), nil
}
doneCh := make(chan struct{})
collector := &BackfillCollector{
UpsertMessages: upsert,
Expand Down