Conversation
E.g., messages from Yandex metrics
✅ Deploy Preview for getmavo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| } | ||
|
|
||
| for (let primitive of nodes) { | ||
| primitive.originalEditorUpdated({force: true}); |
There was a problem hiding this comment.
Was this line removed accidentally or we genuinely don't need it anymore?
There was a problem hiding this comment.
My investigation shows that this line is the one that was added in the first bad commit and caused the regression. The only thing I did was revert the previous version of this code block.
I think I understand why this line was present—we get the same result as when we have the two added lines. However, to add to this, we destroy the original editor observer and replace it with the observer of the clone of the original editor. It works fine if the element is not in the edit mode initially. But when it is, we clone the original editor before Mavo can update expressions and handle the original editor mutations.
There was a problem hiding this comment.
It looks like we need this line since, without it, we break another test with dynamic selects. I should continue working on a proper fix.
| let editor = this.editor ?? this.originalEditor; | ||
|
|
||
| if (editor?.matches("select:not(.mv-options-select")) { | ||
| if (editor?.matches("select:not(.mv-options-select)")) { |
There was a problem hiding this comment.
Whoa, how did this go undetected all this time?!
There was a problem hiding this comment.
We have it not so long as you might imagine—not longer than we have mv-options. 😉 We couldn't detect it thanks to the browser forgiveness, I believe. I checked in the console—both variants return the same result.
2 participants
Fixes regression #996.
The main issue is that we lose the original editor observer when we force the original editor update, so the changes are not picked up when the original editor is updated via an expression.