Use minimist to create alias and default arguments#19
Open
bigtimebuddy wants to merge 2 commits intomax-mapper:masterfrom
Open
Use minimist to create alias and default arguments#19bigtimebuddy wants to merge 2 commits intomax-mapper:masterfrom
bigtimebuddy wants to merge 2 commits intomax-mapper:masterfrom
Conversation
Author
|
Ping |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Love the module, I'm a big fan. Thanks for creating and supporting it.
I have a pretty simple PR that updates the bin entry point to take advantage of minimist's options for defining aliases, defaults, booleans and strings. It uses minimist's parse arguments return instead of creating a new object. Also, it's nicer to have these things be explicitly declared.
If you're happy with the existing arguments/options setup, please feel free to close.