taking a stab at setting api key via global config setup block#31
Open
spilliton wants to merge 1 commit intomaxehmookau:masterfrom
Open
taking a stab at setting api key via global config setup block#31spilliton wants to merge 1 commit intomaxehmookau:masterfrom
spilliton wants to merge 1 commit intomaxehmookau:masterfrom
Conversation
Owner
|
Seems pretty good, I like the approach! Add your name to the readme in the PR anyway and I'll review it in more detail in the coming week when I get a minute. Thank you very much! |
Author
|
Sounds good thanks :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I did not update the Readme yet as I'm not sure if this is how you would like it configured and whatnot...since this would change the method signatures of initializers and such it should prolly be a non-patch version bump I would think :)