Conversation
…amic appId - Changed `applicationId` in `app/build.gradle.kts` to `com.miHoYo.GenshinImpact`. - Refactored `IntentLaunchManager.kt` to use `BuildConfig.APPLICATION_ID` for intent actions instead of hardcoded `app.gamenative` string. This fixes input/launch issues when the package name changes. - Updated `BestConfigServiceTest.kt` to reflect the new package name in test data JSON strings.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
maxjivi05
deleted the
update-package-name-dynamic-support-10047302297913092212
branch
1 participant
Updated the application ID to
com.miHoYo.GenshinImpactas requested. Crucially, I updatedIntentLaunchManager.ktto dynamically construct theLAUNCH_GAMEintent action usingBuildConfig.APPLICATION_ID. This ensures that game launching and shortcut functionality ("input") will continue to work correctly even if the package name is changed again in the future, resolving the reported issue where input stopped working after a rename. I also updated the test data to align with the new package name.PR created automatically by Jules for task 10047302297913092212 started by @maxjivi05