Fix controller input and app name after package rename#5
Conversation
This change addresses issues where controller input and mouse movement failed after renaming the package to `com.miHoYo.GenshinImpact`. It also updates the app name to "GameNative Genshin".
Changes:
1. **Modified `app/src/main/res/values/strings.xml`**: Updated `app_name` to "GameNative Genshin".
2. **Modified `app/src/main/cpp/extras/evshim.c`**: Updated the native input shim to check the `EVSHIM_GAMEPAD_PATH` environment variable for the gamepad memory file path, falling back to the old path only if the variable is unset. This allows dynamic path resolution.
3. **Modified `app/src/main/cpp/extras/CMakeLists.txt`**: Added a build target for `libevshim.so` to ensure the modified C code is compiled and included in the APK.
4. **Modified `app/src/main/java/com/winlator/xenvironment/components/BionicProgramLauncherComponent.java`**:
* Dynamically constructs the gamepad memory path using `filesDir`.
* Sets the `EVSHIM_GAMEPAD_PATH` environment variable for the guest process.
* Points `LD_PRELOAD` to the app's native library directory to load the custom `libevshim.so` instead of the one in `imagefs`.
5. **Modified `app/src/main/java/com/winlator/winhandler/WinHandler.java`**: Updated path construction for gamepad memory files to use `activity.getFilesDir()`, ensuring compatibility with any package name.
6. **Modified `app/src/main/java/com/winlator/core/WineUtils.java`** and **`app/src/main/java/com/winlator/core/DXVKHelper.java`**: Replaced hardcoded `/data/data/app.gamenative` paths with dynamic path resolution using `context` and `imageFs` helpers.
These changes ensure that input handling and file access work correctly regardless of the application's package name.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
Fix controller input and app name after package rename
PR created automatically by Jules for task 6890118157623827968 started by @maxjivi05