fixing errors reported by Edit#62
Merged
maxpareschi merged 1 commit intomaxpareschi:3.14.11-22dogs.developfrom Feb 20, 2025
Merged
fixing errors reported by Edit#62maxpareschi merged 1 commit intomaxpareschi:3.14.11-22dogs.developfrom
maxpareschi merged 1 commit intomaxpareschi:3.14.11-22dogs.developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ISSUE ONE: gather have more than one link
Cause
The last version was chosen by the subset name as oposed of being chosen by task. If one task had more than one subset names that were elegible for gathering, the versioning picked up by each would be different.
Fix
Implemented a function that yields the subset names based on task name and asset name, then I get the highest version number from all the subsets that belong to that task, so for each gather for a same task, now it will always up the version regardless the subset name.
ISSUE TWO: gathers won't get integrated in ftrack
Cause
In the integrate_ftrack_api there where two bugs:
Fix
Implemented a function that yields the subset names based on task name and asset name, then I get the highest version number from all the subsets that belong to that task, so for each gather for a same task, now it will always up the version regardless the subset name.