rectifying index in img to mat conversion #38
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suppose alike what we have done for image conversion in case of grayscale and binary (cd<3), for coloured images also:
"# -1 to have 0-indexing per C++"
" " "if (cd < 3) # grayscale or binary
for j = 1:Base.size(img,2) # index row first (Mat is row-major order)
for k =1:Base.size(img,1) # index column second
# slow algorithm - will try to use pointer method (C++)!
pixset(mat, k-1, j-1, float(img[k,j,1].i))
end
end
end
" " "
Although I haven't run this yet since I was looking through the code from another pc. May be I am misinterpreting the situation.
Thank you.