feat: add wasm support and add example on browser #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
maxwase
requested changes
Jul 18, 2024
Owner
maxwase
left a comment
maxwase
left a comment
There was a problem hiding this comment.
Thank you so much for sharing this unexpected, yet valid usecase for this crate! There are some minor changes that I request and I would love to merge this
zhangzqs
changed the title
maxwase
requested changes
Nov 11, 2025
♻️ refactor(examples/wasm)：更新.gitignore，移除index.js文件，修改index.html结构，添加注释到lib.rs并重构结构体名 ✨ feat(examples/wasm): 在Cargo.toml中为button-driver添加wasm特性，简化lib.rs代码并修改Instant实现 ✨ feat: 在Cargo.toml中添加js-sys依赖；在src/instant.rs中为js_sys::Date实现InstantProvider trait ✨ feat(.github/workflows/rust.yml)：添加Clippy wasm检查、rustup添加wasm32-unknown-unknown目标及wasm示例构建步骤 💡 feat(examples/wasm/src/lib.rs)：添加注释说明使用`JsInstant`类型，更新依赖并替换`Date`为`JsInstant` ✨ feat: 在src/instant.rs中添加JsInstant结构体及相关实现，在src/lib.rs中导出JsInstant 💡 docs: 在src/instant.rs中添加JsInstant的注释说明
zhangzqs
force-pushed
the
wasm-support
branch
from
fbd9bd5 to
94a1098
Compare
Owner
|
Thanks for such an unexpected use-case and contribution! I'll refactor this a bit more and release it soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.