🐛 [#201] Fix warning and error in absence of an optional extra #203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #203 +/- ##
==========================================
+ Coverage 93.54% 93.63% +0.08%
==========================================
Files 17 17
Lines 620 628 +8
==========================================
+ Hits 580 588 +8
Misses 40 40 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CharString
commented
Jan 30, 2026
| RuntimeWarning, | ||
| ) | ||
| if default is undefined: | ||
| return default # don't call _config it will require variable.name! |
Contributor
Author
There was a problem hiding this comment.
IMHO, returning undefined is scuffed. But I don't want to spend more time on fixing the type annotation, since maykin-common has a decent one. And an open ticket to merge missing functionality in there.
Contributor
Author
There was a problem hiding this comment.
Oh.. That ticket was close, but there's still a draft PR: maykinmedia/django-common#34
stevenbal
approved these changes
Feb 2, 2026
stevenbal
deleted the
201-the-optional-dependencies-are-not-actually-optional
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #201
Changes
isdoesn't work on splitting; you get a different list