Skip to content

Missing parameter #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mkmojo wants to merge 542 commits into
base: master
Choose a base branch
from
Open

Missing parameter #5

mkmojo wants to merge 542 commits into from

Conversation

@mkmojo
Copy link

@mkmojo mkmojo commented Dec 1, 2014

In the class DotManager of file ctree/visual/dot_manager.py
The dot_ast_to_file method passed in a wrong parameter filename

    @staticmethod
    def dot_ast_to_file(ast_node, file_name):
        dot_text = ast_node.to_dot()
        dot_output = DotManager.run_dot(dot_text, filename)

This will lead to a global variable filename not found error.

I fixed this by giving DotManager.run_dot() method the correct parameter.

mnpatil17 and others added 30 commits January 2, 2015 16:30
@mnpatil17
Minor fix to fix DeclarationFiller tests.
f69cad9
@mnpatil17
Added hasattr safeguard for the BinaryOp assumption.
cc904f7
@mnpatil17
Added type-inference support for function calls.
ea41888
@mnpatil17
Patched incorrect output bug caused by the addition of FunctionCall h…
2a608f2 
…andling in DeclarationFiller
@mnpatil17
fixed case where we had var1 = 5 + var2 breaking.
54da766
@mnpatil17
fixed the case where there was a BinaryOp that consisted of a functio…
b8d32c4 
…n call and something else.
@mnpatil17
Merge pull request #33 from ucb-sejits/mult-assign-feature
2838c52 
Multiple Assign Feature
@mnpatil17
Added lambda function tests. Tests pass.
237b08a
@pyprogrammer
fixed missing 'reason' arg in test_dot_manager unittest.skip
ab18d8c
@pyprogrammer
reverted changes on transformations because we need to parse the assi…
880bf42 
…gn ast into target,value nodes, not a set of special cases. Also, reverted declfiller changes because the deep lookup was unnecessary. We need to probably recursively traverse the binops to find their types instead of looking one layer deep.
@pyprogrammer
added more tests for test_xforms binops.
ce9a078
@pyprogrammer
added tests for test_xforms augassigns
b63f5fb
@mnpatil17
added a few simple tests for multiple assign.
6828294
@mnpatil17
Added all multiple assign tests.
0b26b6c
@pyprogrammer
added range tests in test_xforms, added functioncall types in declfil…
58d5acf 
…ler for type inference
@mnpatil17
Merge conflicts resolved, ____temp__ notation for multiple assign swa…
6a32c18 
…ps has been added back in.
@pyprogrammer
rewrote fib in test_declfiller to make more pythonic and test more st…
e78da5f 
…uff, make functioncall type inference work (kinda) and realized that DeclFiller should only run on CFiles
@pyprogrammer
skipping lambda tests if py3k since args are different in py3k
3efbac4
@pyprogrammer
forgot that skips require reasons. provided reasons.
f5cb2d9
@pyprogrammer
got < and >= mixed up on skipIfs. Getting kinda late for me to keep w…
7964b2f 
…orking and I'm not thinking really clearly. Hope this one works
@mnpatil17
Minor code cleanup
3adf348
@pyprogrammer
fixed multiple assign for arbitrary nesting, i.e. a,(b,(c,d),e) = 1,(…
de7d2a0 
…2,(3,4),5)
@pyprogrammer
merged conflicts
b71ca5e
@pyprogrammer
added a bit of coverage for 'jit.getFile', made itertools.izip_longes…
fea53bd 
…t import conditional since it's zip_longest in py3k
@mnpatil17
Merge pull request #36 from ucb-sejits/caching-development
1d20473 
Multiple New Features Added to ctree
@pyprogrammer
removed extraneous commits
35c051b
@pyprogrammer
added ignore_errors to deletion in case files were deleted already
8978033
@pyprogrammer
Merge pull request #37 from ucb-sejits/src-deletion-feature
ab957b3 
Src deletion feature
@pyprogrammer
modifed get_common_ctype to return a type if they aren't all the same…
a221e5e 
… (i.e. char*s with ints)
@pyprogrammer
merged
fa51d4b
leonardt and others added 17 commits September 23, 2015 10:21
@leonardt
Initial implementation of hwacha code generator example
e1af98c
@leonardt
Update get_type interface, fix test for single assignment case
1ad8aa8
@leonardt
Generate code using map for implicit vectorization
f8c6861
@leonardt
Use hwacha_map and int32g
1cc33da
@leonardt
use list(map for py3
a615af6
@leonardt
Generate vector assembly
1d6fe44
@dorthyluu
Updated dgemm example for autotuning showcasing
0abbd8d
@leonardt
Merge remote-tracking branch 'origin/development'
3efdbab
@dorthyluu
added requirements comment
c0561c2
@chick
Merge branch 'Rebox'
1a3199b
@chick
Fixed test of omp end to end by adding clamp macro to the omp Functio…
bb4e7ac 
…nDecl handler

Better handling of hindemith non-existence or error
Fix looking inside call node for name attr, might not be present
@chick
artifact of trying to get test_examples to work
f3db593
@leonardt
Add more simd types, some python3 bugfixes
5f861b8
@leonardt
Remove fglrx version
0688ca3
@leonardt
Install opencl manually
77392ed
@leonardt
Add amd sdk setup script
1c991ca
@leonardt
Set pycl env variable
a0fd1b5
@coveralls
Copy link

coveralls commented Oct 2, 2016

Coverage Status

Changes Unknown when pulling a0fd1b5 on ucb-sejits:master into * on mbdriscoll:master*.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@mkmojo @coveralls @mnpatil17 @pyprogrammer @leonardt @chick @dorthyluu @hsadok @mbdriscoll