Skip to content

Conversation

@mbifulco
Copy link
Owner

@mbifulco mbifulco commented Dec 2, 2025

No description provided.

Copilot AI review requested due to automatic review settings December 2, 2025 15:21
@vercel
Copy link

vercel bot commented Dec 2, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
mikebifulco-com-bnbu Ready Ready Preview Comment Dec 2, 2025 3:40pm

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses an email rendering issue where emojis were appearing on separate lines in newsletter emails. The fix involves adding CSS rules to display emojis inline with text and refactoring Text components to keep content together on single lines.

Key Changes

  • Added CSS rules targeting emoji images with img[data-emoji] selector to force inline-block display with proper sizing
  • Consolidated multi-line Text components into single-line components to prevent unwanted line breaks
  • Split the sign-off message into two separate Text components for proper formatting

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
src/utils/email/templates/NewsletterEmail.tsx Refactored Text components to single lines and split sign-off message into two separate components
src/utils/email/templates/EmailLayout.tsx Added CSS rules for emoji styling and consolidated footer text into single line

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

</Link>
. It helps me out a great deal!
</Text>
<Text className="italic text-gray-500">Thanks for reading 💌 Tiny Improvements. If you found this helpful, I'd love it if you <Link href="https://mikebifulco.com/newsletter" className="text-pink-600">share it with a friend</Link>. It helps me out a great deal!</Text>
Copy link

Copilot AI Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is extremely long (221 characters) and significantly impacts code readability and maintainability. Consider breaking it into multiple lines while keeping the content inline. For example:

<Text className="italic text-gray-500">
  Thanks for reading 💌 Tiny Improvements. If you found this helpful, I'd love it if you <Link href="https://mikebifulco.com/newsletter" className="text-pink-600">share it with a friend</Link>. It helps me out a great deal!
</Text>

This maintains the inline rendering while improving code readability.

Suggested change
<Text className="italic text-gray-500">Thanks for reading 💌 Tiny Improvements. If you found this helpful, I'd love it if you <Link href="https://mikebifulco.com/newsletter" className="text-pink-600">share it with a friend</Link>. It helps me out a great deal!</Text>
<Text className="italic text-gray-500">
Thanks for reading 💌 Tiny Improvements. If you found this helpful, I'd love it if you{' '}
<Link
href="https://mikebifulco.com/newsletter"
className="text-pink-600"
>
share it with a friend
</Link>
. It helps me out a great deal!
</Text>

Copilot uses AI. Check for mistakes.
mikebifulco.com
</Link>
</Text>
<Text className="my-0 text-sm">© {new Date().getFullYear()} &bull; 💌 Tiny Improvements &bull; <Link href="https://mikebifulco.com/newsletter" className="text-pink-600">mikebifulco.com</Link></Text>
Copy link

Copilot AI Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is extremely long (198 characters) and significantly impacts code readability and maintainability. Consider breaking it into multiple lines while keeping the content inline. For example:

<Text className="my-0 text-sm">
  © {new Date().getFullYear()} &bull; 💌 Tiny Improvements &bull; <Link href="https://mikebifulco.com/newsletter" className="text-pink-600">mikebifulco.com</Link>
</Text>

This maintains the inline rendering while improving code readability.

Suggested change
<Text className="my-0 text-sm">© {new Date().getFullYear()} &bull; 💌 Tiny Improvements &bull; <Link href="https://mikebifulco.com/newsletter" className="text-pink-600">mikebifulco.com</Link></Text>
<Text className="my-0 text-sm">
© {new Date().getFullYear()} &bull; 💌 Tiny Improvements &bull;{' '}
<Link href="https://mikebifulco.com/newsletter" className="text-pink-600">
mikebifulco.com
</Link>
</Text>

Copilot uses AI. Check for mistakes.
}
img {
max-width: 100% !important;
height: auto !important;
Copy link

Copilot AI Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The removal of display: block !important; from the general img selector may have unintended consequences for other images in the email (like the logo or footer images). This could cause layout issues with regular images that were relying on block display.

Consider keeping the block display for the general img selector and only overriding it for emoji images:

img {
  max-width: 100% !important;
  height: auto !important;
  display: block !important;
}
img[data-emoji] {
  display: inline-block !important;
  vertical-align: middle !important;
  height: 1em !important;
  width: auto !important;
  margin: 0 !important;
}
Suggested change
height: auto !important;
height: auto !important;
display: block !important;

Copilot uses AI. Check for mistakes.
@mbifulco mbifulco merged commit 4f3d351 into main Dec 2, 2025
9 checks passed
@mbifulco mbifulco deleted the newsletter/mirror branch December 2, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants