Expose featureCount property. Fixes #40.
#41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Could we call it “size” instead of “featureCount”? |
Author
|
Might be confused with file size, but up to you. |
petitlegume
suggested changes
Jan 13, 2021
petitlegume
left a comment
petitlegume
left a comment
There was a problem hiding this comment.
It shoud use getUint32 instead of getUint16. The number of records in the file refers to the byte offset 4 - 7 in the DBF head.
petitlegume
pushed a commit
to petitlegume/shapefile
that referenced
this pull request
Jan 13, 2021
…m bytes 4-7. this fixes mbostock#41.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.