Skip to content

Search with Media shortcode #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Philmod wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Search with Media shortcode #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
27fba72
dev dependencies
Oct 14, 2014
183e7c2
search media by shortcode
Oct 14, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/class.instagram.media.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,11 @@ class InstagramMedia

info: (params) ->
credentials = @parent._credentials {}
params['path'] = "/#{@parent._api_version}/media/#{params['media_id']}?#{@parent._to_querystring(credentials)}"
if params['media_shortcode']
path = "/media/shortcode/#{params['media_shortcode']}"
else
path = "/media/#{params['media_id']}"
params['path'] = "/#{@parent._api_version}#{path}?#{@parent._to_querystring(credentials)}"
@parent._request params

search: (params) ->
Expand Down
36 changes: 20 additions & 16 deletions lib/class.instagram.media.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,11 @@
"directories": {
"lib": "./lib"
},
"devDependencies": {
"express": "3.17.7",
"expresso": "*",
"should": "*"
},
"files": [
""
],
Expand Down
7 changes: 7 additions & 0 deletions test/instagram.media.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,13 @@ module.exports =
data.should.have.property 'created_time', '1279315783'
test.output "data had the property 'created_time' equal to 1279315783"
app.finish_test()
'media#info for shortcode#33': ->
test.helper 'media#info for shortcode#33', Instagram, 'media', 'info', { media_shortcode: 33 }, (data) ->
data.should.have.property 'shortcode', '33'
test.output "data had the property 'shortcode' equal to 33"
data.should.have.property 'created_time', '1279315783'
test.output "data had the property 'created_time' equal to 1279315783"
app.finish_test()
'media#search for 48.858844300000001/2.2943506': ->
test.helper 'media#search for 48.858844300000001/2.2943506', Instagram, 'media', 'search', { lat: 48.858844300000001, lng: 2.2943506 }, (data) ->
data.length.should.be.above 0
Expand Down
24 changes: 17 additions & 7 deletions test/instagram.media.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.