Merged
Conversation
…o parallel workers in API as well as locally
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses Issue #112
Problem
Bulk simulations in the WOFOST API were opening a new database connection for every parcel in parallel runs. When many runs were submitted at once, this caused PostgreSQL connection exhaustion and
NoneType/to_crserrors.Solution
Introduced a centralized SQLAlchemy session factory (
SessionLocal) inukwofost.core.utility.db.FastAPI endpoints now inject a scoped session via
Depends(get_db)for sequential runs.Simulation functions (
Parcel,run_wofost_simulation,run_from_payload) were refactored to accept a db session parameter.For parallel execution, each worker process creates its own session from
SessionLocal(), preventing cross-process session sharing and pickling issues.Sequential execution reuses the injected session to minimize connection usage.