feat: Protect home page with Angular Guards #144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcruzdev
requested changes
Dec 12, 2025
Owner
mcruzdev
left a comment
mcruzdev
left a comment
There was a problem hiding this comment.
Thanks again @matheusandre1, for your great effort and collaboration.
I left an important comment.
| constructor(private readonly router: Router) {} | ||
|
|
||
| private isLogged(): boolean { | ||
| return localStorage.getItem(timelessLocalStorageKey) != null; |
Owner
There was a problem hiding this comment.
Hi @matheusandre1, we have a problem here, we can easily set a key with the same name in the localStorage and this code will return true.
Let's verify if the token is valid in the backend, WDYT?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#50
The issue would be that, but it also has something to do with... #36.
We have to see how the problems, when solved, complement each other, because on the back-end SignInResponse has the token, the ID, etc., while on the front-end, it only has the token. In the local storage part, okay, it might work, but there could be some security problem in that part, which I wouldn't know how to identify at the moment.