Add Tinycrypt based SHA-512 for ED25519#627
Merged
utzig merged 3 commits intomcu-tools:masterfrom Feb 4, 2020
Merged
Conversation
Member
Author
|
This needs to be rebased after #629 is merged for it to fail as would be expected. |
utzig
force-pushed
the
tinycrypt-sha512
branch
from
8b24379 to
d6a7f79
Compare
A patch adding sha-512 to upstream tinycrypt was submitted: intel/tinycrypt#42 While it is not accepted, add the code under a new ext/tinycrypt-sha512 depedency. Signed-off-by: Fabio Utzig <utzig@apache.org>
Add option to build ed25519 with tinycrypt; enable tinycrypt based sha-512 for ed25519 sim tests. Signed-off-by: Fabio Utzig <utzig@apache.org>
utzig
force-pushed
the
tinycrypt-sha512
branch
from
d6a7f79 to
7169256
Compare
* Mynewt always uses sha-512 from tinycrypt * Zephyr can choose either tinycrypt or mbedTLS Signed-off-by: Fabio Utzig <utzig@apache.org>
Member
Author
|
@d3zd3z To avoid stalling a new release, I updated this PR adding sha-512 for tinycrypt in another external included library. It is being tested on the sim, and I tested it on Mynewt and Zephyr. |
d3zd3z
approved these changes
Feb 3, 2020
Member
d3zd3z
left a comment
d3zd3z
left a comment
There was a problem hiding this comment.
LGTM. I agree about merging this, and then cleaning up once it is merged upstream.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add option to build ed25519 with Tinycrypt.
This depends on intel/tinycrypt#42 being accepted and update of local copy.
UPDATE: sha-512 was added separately while upstream PR is pending acceptance.