Fix: library card member counts exclude inactive users #316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Library cards were displaying inflated member counts by including inactive users in the totals. This update ensures accurate member count display across all API endpoints by filtering `_count.members` queries for `{ isActive: true }`.
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
Resolved double-counting issue where member counts were inconsistent between endpoints. The root cause was that `members` relation queries filtered by both `isActive: true` and `user: { status: 'active' }`, but `_count.members` queries only filtered by `isActive: true`.
Updated all `_count.members` queries to consistently filter for active members with active user accounts, ensuring accurate member counts across all library cards and API responses.
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Align library member counts across API endpoints to include only active users. This fixes inflated counts on library cards and collection views.
Changes
Ensure consistency in:
Why
Member counts previously included inactive users, leading to confusing totals on the library card and detail pages.
Impact
Test Plan