Skip to content

perf: iterate over CardPlay without allocation #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mdgoldberg merged 1 commit into from
Jan 18, 2026
Merged

perf: iterate over CardPlay without allocation #4

mdgoldberg merged 1 commit into from
Jan 18, 2026

Conversation

@mdgoldberg
Copy link
Owner

@mdgoldberg mdgoldberg commented Nov 7, 2025

Summary

  • add CardPlay::cards() iterator + CardPlayCards
  • swap display, validation, and gameplay logic to iterate instead of cloning vecs
  • left to_vec() delegating to the iterator for compatibility
  • verified with cargo test -p types and cargo test -p strategies

@mdgoldberg mdgoldberg enabled auto-merge January 18, 2026 16:31
@mdgoldberg mdgoldberg merged commit b728136 into main Jan 18, 2026
4 checks passed
@mdgoldberg mdgoldberg deleted the perf/cardplay-iter branch January 18, 2026 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mdgoldberg