Skip to content

Fix udp buffer overflows #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pfink wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix udp buffer overflows #115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b23fa6
Fix UDP buffer overflow
pfink Jan 16, 2021
b918d58
Fix UDP rx buffer overflow
pfink Jan 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libraries/Bridge/src/BridgeUdp.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ int BridgeUDP::parsePacket(){
}
remote_ip = IPAddress(si_other.sin_addr.s_addr);
remote_port = ntohs(si_other.sin_port);
rx_buffer = new cbuf(len);
rx_buffer = new cbuf(len+1);
rx_buffer->write(buf, len);
return len;
}
Expand Down
2 changes: 1 addition & 1 deletion libraries/Bridge/src/BridgeUdp.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ class BridgeUDP : public UDP {
IPAddress multicast_ip;
IPAddress remote_ip;
uint16_t remote_port;
char buffer[1460];
char buffer[1500];
size_t buffer_len;
cbuf * rx_buffer;
public:
Expand Down