First pass at OpenSearch locally #348
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skyemeedan
reviewed
Oct 6, 2023
Contributor
skyemeedan
left a comment
skyemeedan
left a comment
There was a problem hiding this comment.
lol my questions are pretty much in the PR template: was there a ticket for this to link back to? (this was the local part of the ES migration right?), Assuming you tested by running (something) locally and it worked? Are there parts that didn't work that require a second pass?
| environment: | ||
| ELASTICSEARCH_URL: http://elasticsearch:9200 | ||
| - "elasticsearch:/usr/share/opensearch/data" | ||
| # kibana: |
Contributor
There was a problem hiding this comment.
assume kibana is no longer needed ... what were we using it for with ES?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a very brief high-level description of the problem or feature and technical details or specific code changes on PR
Reference: TICKET-ID (to provide additional context)
How has this been tested?
Has it been tested locally? Are there automated tests?
Have you considered secure coding practices when writing this code?
Please list any security concerns that may be relevant.