Skip to content

Conversation

@melsawy
Copy link
Contributor

@melsawy melsawy commented Jan 11, 2026

Description

Disable user registration and restrict user to invitation only

References: CV2-6599

How to test?

  • Run automated test
  • Manual test (added more details here)
  • Run check-web tests

Checklist

  • I have performed a self-review of my code and ensured that it is safe and runnable, that code coverage has not decreased, and that there are no new Code Climate issues. I have also followed Meedan's internal coding guidelines.

@melsawy melsawy marked this pull request as ready for review January 14, 2026 15:03
Copy link
Contributor

@caiosba caiosba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@melsawy, you should also update the config/routes.rb file, right?

@melsawy
Copy link
Contributor Author

melsawy commented Jan 15, 2026

@melsawy, you should also update the config/routes.rb file, right?

right Caio and also I removed the welcome email and duplicate email

@melsawy melsawy requested a review from caiosba January 15, 2026 09:06
@vasconsaurus
Copy link
Contributor

@melsawy I went over the code, but I don't think I had any questions besides the ones @caiosba already asked.

I was trying to manually test it, but I'm having some trouble running the API. I'll poke around, try to fix it, and let you know once I'm able to test it.

@vasconsaurus
Copy link
Contributor

@melsawy I was able to run a first test, I tried to register without having an invitation code. But it just failed silently, it didn't notify me of what was happening. Here is a video:

Screen.Recording.2026-01-15.at.10.47.19.mov

I was also wondering if we shouldn't remove the sign-up option, since we now only allow registration through the invite code, and you can't really just sign-up. What do you think?

Screenshot 2026-01-15 at 10 48 06

@melsawy
Copy link
Contributor Author

melsawy commented Jan 15, 2026

I was also wondering if we shouldn't remove the sign-up option, since we now only allow registration through the invite code, and you can't really just sign-up. What do you think?

Already I removed sign-up, you should test using same branch for check-web: CV2-6599-restrict-user-registration-to-invitation-only

@vasconsaurus
Copy link
Contributor

I was also wondering if we shouldn't remove the sign-up option, since we now only allow registration through the invite code, and you can't really just sign-up. What do you think?

Already I removed sign-up, you should test using same branch for check-web: CV2-6599-restrict-user-registration-to-invitation-only

I checked, and it looks like I was in the correct branch 🤔 I'll retry this later

@melsawy
Copy link
Contributor Author

melsawy commented Jan 15, 2026

@melsawy I was able to run a first test, I tried to register without having an invitation code. But it just failed silently, it didn't notify me of what was happening

@vasconsaurus I raised error here and should handle the message in check-web branch

@melsawy melsawy requested a review from caiosba January 15, 2026 16:59
Copy link
Contributor

@caiosba caiosba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Sawy for addressing my previous comments

Copy link
Contributor

@vasconsaurus vasconsaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got my basic test to work! Thanks, @melsawy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants