6473 add otel config #108
6473 add otel config #108
Conversation
|
@danielevalverde, I added you as reviewer just in case this breaks anything for you. |
Since the otel-collector is relevant to all Check services, we don't want to keep it in individual repos, but keep it in the main Check one. This is only relevant to local development. References: CV2-6473, CV2-4396 Relates to: meedan/check#108
Since this is not only specific to Pender, but can and should be used for other services
The developer can uncomment the env_file section if they generated it and want to use it for local development.
vasconsaurus
force-pushed
the
6473-add-otel-config
branch
from
153ef03 to
283cc8e
Compare
There was a problem hiding this comment.
Are the commented lines in this file here because we don’t need them anymore (in which case, why not just delete them?), or because we’re supposed to uncomment them to enable something?
If it’s the latter, could you please add comments to clarify this (or add instructions to the README)?
For example: “Uncomment the X lines below to enable OTEL.”
There was a problem hiding this comment.
When we first added the otel-collector we opted to keep it commented out, because we won't be running by default locally. I'll add a comment, and see if it makes sense to add something to the README.
caiosba
left a comment
caiosba
left a comment
There was a problem hiding this comment.
Thanks Manu for applying the suggestion!
We are using the otel-collector mainly to be able to collect custom metrics from our Rails services. But it is a service that can be used with any of Check's services.
Because it is relevant to all of our services we don't want to keep it in individual repos, but keep it in the main Check one.
This is only relevant to local development.
References: CV2-6473, CV2-4396
Relates to: meedan/pender#586