New functions to check ALL filesystems of a given type #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use NHC on many file servers to check the filesystem usage, and we have wound up with a total of 75 lines in nhc.conf similar to this one:
niflfs7.fysik.dtu.dk || check_fs_used /u/camd 90%
All these many lines are difficult to maintain, and therefore it is desirable to have catch-all checks that apply to ALL filesystems of a given type, for example, XFS filesystems.
This PR proposes four new functions that supplement check_fs_* functions: check_all_fs_inodes, check_all_fs_ifree, check_all_fs_iused, check_all_fs_used. The nwe functions simply loop over all filesystems and calls the original check_fs_* functions on each filesystem of the given type.
An example usage is: