Skip to content
This repository was archived by the owner on Oct 26, 2018. It is now read-only.

a few small fixes for cloudfront_asset_host #6

Open
robertzx wants to merge 28 commits into
base: master
Choose a base branch
from
Open

a few small fixes for cloudfront_asset_host #6

robertzx wants to merge 28 commits into from

Conversation

@robertzx
Copy link

@robertzx robertzx commented Nov 9, 2010

Awesome gem! This was a lifesaver.

I've got a few changes on my fork that you might want:

  • When an asset is excluded by the exclude pattern, the tag helpers shouldn't generate Cloudfront URLs because the asset (probably) won't be there.
  • The CSS image URL got overly greedy on non-quoted URLs in some cases - this mostly bit me on minified CSS files generated by Jammit
  • Test cases for both of the above.
  • Example rake task for uploading

thanks,
Robert

rsanders and others added 28 commits November 8, 2010 13:57
@rsanders
fix CSS host regex
29b4c32
@rsanders
only perform cloudfront-style rewriting on assets that have not been …
ad4dbb4 
…excluded from the CDN
@rsanders
include base .specification file for braid's sake
08f711f
@rsanders
update tests to match new extension methods
8f1c259
@rsanders
test for runaway URL regex bugfix
5cca223
@rsanders
only use cloudfront tag helper extensions if currently enabled; don't…
b84456b 
… re-alias_method_chain if already done.
@rsanders
bring in rails as a dependency for the helper tests (there's probably…
d34c8ae 
… a better way)
@rsanders
make it easier to run a test with "ruby <filename>" from anywhere in …
fa9d6f4 
…the tree
@rsanders
test for asset tag helper behavior for excluded paths
9bac459
@rsanders
rake upload task
ff1d938
@rsanders
remove spurious .specification file
2fd6699
@rsanders
add some speculative font mime types (widespread disagreement on this)
8be467b
@rsanders
Merge branch 'release/v1.1.0_mime'
ee27d8b 
* release/v1.1.0_mime:
  add some speculative font mime types (widespread disagreement on this)
@rsanders
add bugs file
3808e69
@rsanders
ignore :cache=>true all.{js,css} files
0f5b89b
@rsanders
if stylesheet or javascript include/link tags have recursive or cache…
2450fe2 
… => true, don't use CF asset host

if any asset source name matches "^//", treat it as a full URL in compute_public_path
@rsanders
fix bug in tests related to timestamp/asset_id caching
ad583c1
Removed expiry header as requested by PT 27722733
824c6de
@robertzx
Merge pull request #2 from zeevex/feature/remove_expiry_header
7720964 
Feature/remove expiry header
@sudish
Use ERB to process paperclip.yml.
b3991b1
@sudishzx
Merge pull request #3 from zeevex/feature/use-erb-when-reading-configs
b074994 
Use erb when reading configs
@sudish
Bumped version to z1.1.0.4
9f61e59
@sudish
Merge branch 'release/z1.1.0.4'
adf1fb7 
* release/z1.1.0.4:
  Bumped version to z1.1.0.4
  Use ERB to process paperclip.yml.
@sudish
Merge branch 'release/z1.1.0.4' into develop
8bc8ebd 
* release/z1.1.0.4:
  Bumped version to z1.1.0.4
@robertzx
fix case mismatch with right_aws
ea3af99
@robertzx
Merge branch 'master' into develop
ed41905 
* master:
  fix case mismatch with right_aws
  Removed expiry header as requested by PT 27722733
  fix bug in tests related to timestamp/asset_id caching
  if stylesheet or javascript include/link tags have recursive or cache => true, don't use CF asset host if any asset source name matches "^//", treat it as a full URL in compute_public_path
  ignore :cache=>true all.{js,css} files
  add bugs file
  add some speculative font mime types (widespread disagreement on this)
@robertzx
rails3 fixes
9713e70
@robertzx
bump version
36ac123
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@robertzx @rsanders @sudish @sudishzx