Skip to content

chore: add Node.js 24.x and start migrate tests to node test#133

Merged
jonnydgreen merged 2 commits intomercurius-js:mainfrom
Puppo:chore-prepare-migration-to-node-test
Dec 16, 2025
Merged

chore: add Node.js 24.x and start migrate tests to node test#133
jonnydgreen merged 2 commits intomercurius-js:mainfrom
Puppo:chore-prepare-migration-to-node-test

Conversation

@Puppo
Copy link
Contributor

@Puppo Puppo commented Dec 14, 2025

This PR starts the migration from tap to node test runner

@Puppo Puppo changed the title chore: add Node.js 24.x and migrate tests to borp chore: add Node.js 24.x and start migrate tests to node test Dec 14, 2025
Copy link
Contributor

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Puppo
Copy link
Contributor Author

Puppo commented Dec 15, 2025

@mcollina, sorry if I bother you.
Do you think we can merge this one? Doing so, I can convert #134 to review, since it depends on this one.

Copy link
Collaborator

@jonnydgreen jonnydgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :) I'm afk today but can merge tomorrow if needed as well!

@Puppo
Copy link
Contributor Author

Puppo commented Dec 16, 2025

lgtm :) I'm afk today but can merge tomorrow if needed as well!

@jonnydgreen no rush. when you can it will be perfect.

@jonnydgreen jonnydgreen merged commit 448ba62 into mercurius-js:main Dec 16, 2025
10 checks passed
@jonnydgreen
Copy link
Collaborator

All merged! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants