-
Notifications
You must be signed in to change notification settings - Fork 283
fix(MM2-2099): add date filters to VendorGetProductTypesParams for improved querying #541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Conversation
|
|
🚅 Deployed to the mercur-pr-541 environment in [DEV & QA] mercur-internal
|
| import { createFindParams } from '@medusajs/medusa/api/utils/validators' | ||
| import { createFindParams } from "@medusajs/medusa/api/utils/validators"; | ||
|
|
||
| const dateFilterSchema = z |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe here you can use Medusa's createOperatorMap() function from their API utils?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have extracted dateFilterSchema to shared location in packages/modules/b2c-core/src/shared/infra/http/utils/zod.ts
We can use Miłosz solution until we figure out if we want to make a switch to bracket notation on FE and then on backend use Medusa'screateOperatorMap().
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
…oduct-types-view-throws-an-error
No description provided.