Conversation
Licenses management page was migrated over to https://admin.cloud.microsoft/?#/licenses causing enlicense.cmd.ms to no longer be an effective shortcut.
Summary of ChangesHello @Confrigid, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an outdated shortcut for licenses management by updating the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the shortcuts for license management pages. It splits the previous enlicense command, which had adlicense as an alias, into two distinct commands: enlicense for the Entra portal and a new adlicense for the Microsoft 365 admin center. This reflects the migration of the licenses page. My review includes a suggestion to improve the naming consistency of the new command to better align with existing patterns in the project.
| enpumfa,enlegacymfa|adlegacymfa,Legacy MFA,,Entra,https://entra.microsoft.com/#view/Microsoft_AAD_IAM/MultifactorAuthenticationConfig.ReactView/tabId/users | ||
| enlicense,adlicense,Licenses,,Entra,https://entra.microsoft.com/#view/Microsoft_AAD_IAM/LicensesMenuBlade/~/Products | ||
| enlicense,,Licenses,,Entra,https://entra.microsoft.com/#view/Microsoft_AAD_IAM/LicensesMenuBlade/~/Products | ||
| adlicense,,Licenses,,Microsoft 365,https://admin.cloud.microsoft/?#/licenses |
There was a problem hiding this comment.
The ad prefix is consistently used for Microsoft Entra services in this project (e.g., adgroups, adusers). Using adlicense for a Microsoft 365 admin center link is inconsistent with this pattern. To maintain clarity and consistency, I suggest renaming this command to adminlicense. This aligns well with the existing admin command which points to the Microsoft 365 admin center.
adminlicense,,Licenses,,Microsoft 365,https://admin.cloud.microsoft/?#/licenses
Licenses management page was migrated over to https://admin.cloud.microsoft/?#/licenses causing enlicense.cmd.ms to no longer be an effective shortcut.