Skip to content

Update commands.csv#182

Open
Confrigid wants to merge 1 commit intomerill:mainfrom
Confrigid:patch-1
Open

Update commands.csv#182
Confrigid wants to merge 1 commit intomerill:mainfrom
Confrigid:patch-1

Conversation

@Confrigid
Copy link

Licenses management page was migrated over to https://admin.cloud.microsoft/?#/licenses causing enlicense.cmd.ms to no longer be an effective shortcut.

Licenses management page was migrated over to https://admin.cloud.microsoft/?#/licenses causing enlicense.cmd.ms to no longer be an effective shortcut.
@gemini-code-assist
Copy link

Summary of Changes

Hello @Confrigid, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an outdated shortcut for licenses management by updating the adlicense command. It ensures that users are directed to the correct, newly migrated licenses management page within the Microsoft 365 admin center, improving the accuracy and usability of the command.

Highlights

  • Update adlicense command URL: The URL for the adlicense command has been updated to point to the new Microsoft 365 admin portal for licenses management: https://admin.cloud.microsoft/?#/licenses.
  • Separate adlicense entry: The adlicense alias, previously part of the enlicense entry, has been given its own distinct entry in commands.csv to accommodate its new URL and scope.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the shortcuts for license management pages. It splits the previous enlicense command, which had adlicense as an alias, into two distinct commands: enlicense for the Entra portal and a new adlicense for the Microsoft 365 admin center. This reflects the migration of the licenses page. My review includes a suggestion to improve the naming consistency of the new command to better align with existing patterns in the project.

enpumfa,enlegacymfa|adlegacymfa,Legacy MFA,,Entra,https://entra.microsoft.com/#view/Microsoft_AAD_IAM/MultifactorAuthenticationConfig.ReactView/tabId/users
enlicense,adlicense,Licenses,,Entra,https://entra.microsoft.com/#view/Microsoft_AAD_IAM/LicensesMenuBlade/~/Products
enlicense,,Licenses,,Entra,https://entra.microsoft.com/#view/Microsoft_AAD_IAM/LicensesMenuBlade/~/Products
adlicense,,Licenses,,Microsoft 365,https://admin.cloud.microsoft/?#/licenses

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The ad prefix is consistently used for Microsoft Entra services in this project (e.g., adgroups, adusers). Using adlicense for a Microsoft 365 admin center link is inconsistent with this pattern. To maintain clarity and consistency, I suggest renaming this command to adminlicense. This aligns well with the existing admin command which points to the Microsoft 365 admin center.

adminlicense,,Licenses,,Microsoft 365,https://admin.cloud.microsoft/?#/licenses

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant