Conversation
Just to get started, add sanity-check tests of our `calc_dist` euclidean distance calculating function in lib/common.py Use the `unittest` python module because it's built-in.
Make sure for the first node case we: - return a node - it is within bounds For the second node case, additionally: - it is NOT within conf.MINDIST of origin node - it IS within radio range of origin node The radio range computation in the test is identical to the function so this is not ideal. Additionally, the found node is random each test run, so use f-strings in the failure messages to aid in troubleshooting any test failures which might happen.
zandi
force-pushed
the
feature/unit-tests
branch
from
39985e2 to
8eb8629
Compare
GUVWAF
approved these changes
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add initial basic unit tests. Now that there are unit tests, future PRs can add more tests to improve coverage, and include their own tests for new features/fixed bugs.