Skip to content

Conversation

@thebentern
Copy link
Contributor

No description provided.

@thebentern thebentern requested a review from Copilot August 17, 2025 11:12

This comment was marked as outdated.

thebentern and others added 5 commits August 17, 2025 06:18
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@thebentern thebentern requested a review from Copilot August 17, 2025 11:22

This comment was marked as outdated.

thebentern and others added 4 commits August 17, 2025 06:31
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@thebentern thebentern requested a review from Copilot August 17, 2025 11:32
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a comprehensive testing framework and XEdDSA signing infrastructure for the Meshtastic C# library. The changes include device discovery capabilities, cryptographic signing features, and integration testing infrastructure to support real hardware testing scenarios.

  • Device discovery system for Linux and macOS USB devices with Meshtastic vendor ID detection
  • XEdDSA (Extended EdDSA) signing implementation for NodeInfo packet authentication
  • Integration testing framework with hardware device support and automated discovery

Reviewed Changes

Copilot reviewed 19 out of 22 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
protobufs Updated subproject commit reference
Meshtastic/Meshtastic.csproj Added LibUsbDotNet package dependency
Meshtastic/Discovery/MeshtasticDevice.cs Device model with hardware detection logic
Meshtastic/Discovery/DeviceDiscovery.cs Cross-platform USB device discovery implementation
Meshtastic/Data/MessageFactories/NodeInfoMessageFactory.cs Factory for creating signed NodeInfo messages
Meshtastic/Crypto/XEdDSASigning.cs XEdDSA cryptographic signing implementation
Meshtastic.IntegrationTest/* Complete integration testing framework
Directory.Packages.props Added LibUsbDotNet package version
Comments suppressed due to low confidence (1)

Meshtastic/Crypto/XEdDSASigning.cs:55

  • Missing using directive for System.Text. The code uses Encoding.ASCII.GetBytes() on line 55 but the using directive is not present at the top of the file.
        byte[] domain = Encoding.ASCII.GetBytes("XEdDSA");

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

thebentern and others added 3 commits August 17, 2025 06:37
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@thebentern thebentern merged commit 3bdf8cd into master Aug 18, 2025
4 checks passed
@thebentern thebentern deleted the e2e-tests branch August 18, 2025 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants