-
-
Notifications
You must be signed in to change notification settings - Fork 20
Testing framework WIP and XeDSA signing infra #123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a comprehensive testing framework and XEdDSA signing infrastructure for the Meshtastic C# library. The changes include device discovery capabilities, cryptographic signing features, and integration testing infrastructure to support real hardware testing scenarios.
- Device discovery system for Linux and macOS USB devices with Meshtastic vendor ID detection
- XEdDSA (Extended EdDSA) signing implementation for NodeInfo packet authentication
- Integration testing framework with hardware device support and automated discovery
Reviewed Changes
Copilot reviewed 19 out of 22 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| protobufs | Updated subproject commit reference |
| Meshtastic/Meshtastic.csproj | Added LibUsbDotNet package dependency |
| Meshtastic/Discovery/MeshtasticDevice.cs | Device model with hardware detection logic |
| Meshtastic/Discovery/DeviceDiscovery.cs | Cross-platform USB device discovery implementation |
| Meshtastic/Data/MessageFactories/NodeInfoMessageFactory.cs | Factory for creating signed NodeInfo messages |
| Meshtastic/Crypto/XEdDSASigning.cs | XEdDSA cryptographic signing implementation |
| Meshtastic.IntegrationTest/* | Complete integration testing framework |
| Directory.Packages.props | Added LibUsbDotNet package version |
Comments suppressed due to low confidence (1)
Meshtastic/Crypto/XEdDSASigning.cs:55
- Missing using directive for System.Text. The code uses
Encoding.ASCII.GetBytes()on line 55 but the using directive is not present at the top of the file.
byte[] domain = Encoding.ASCII.GetBytes("XEdDSA");
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
No description provided.