Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for the Sensirion SCD30 CO₂ sensor to the Air Quality Telemetry pipeline, including I2C auto-detection, integration into the telemetry sensor registry, and build-time dependency wiring.
Changes:
- Introduce a new
SCD30SensorTelemetrySensor implementation (metrics + admin configuration hooks). - Add SCD30 discovery support to I2C scanning and register it in the Air Quality Telemetry module.
- Add the Sensirion SCD30 PlatformIO library dependency; minor log/flow tweaks in existing Sensirion sensor code.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
src/modules/Telemetry/Sensor/SEN5XSensor.cpp |
Adjusts idle/state-save control flow for SEN5X VOC state handling. |
src/modules/Telemetry/Sensor/SCD4XSensor.cpp |
Log message cleanups and minor formatting changes. |
src/modules/Telemetry/Sensor/SCD30Sensor.h |
Declares the new SCD30 telemetry sensor class. |
src/modules/Telemetry/Sensor/SCD30Sensor.cpp |
Implements SCD30 initialization, measurements, and admin-config handlers. |
src/modules/Telemetry/AirQualityTelemetry.cpp |
Wires SCD30 into the air quality sensor scan/add sequence. |
src/detect/ScanI2CTwoWire.cpp |
Adds SCD30 address detection to the I2C scanner. |
src/detect/ScanI2C.h |
Adds SCD30 to the DeviceType enum. |
src/configuration.h |
Defines the SCD30 I2C address constant. |
platformio.ini |
Adds the Sensirion I2C SCD30 library to relevant environments. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
343787a to
0a9ab42
Compare
Member
|
@oscgonfer i pulled the protobuf into develop. can you have a look at the findings of copilot? |
* Fix casting float-uint16_t * Pass 100 for resetting temperature offset
Contributor
Author
|
@caveman99 all done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Yet another CO2 sensor from Sensirion. Needs meshtastic/protobufs#861
🤝 Attestations