You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Radiolib includes the lora.getFrequencyError() function to return the offset from expected frequency center. This can be added to meshpacket and used to help debug mesh problems.
I'll reiterate my comments on Discord.
I don't think it's worth saving this in the MeshPacket as it will lead to increased RAM usage quite a lot (~5 bytes per packet in the Tx queue, phone queue, etc.).
The value is also very hard to interpret. It can be that the transmitter is off, the receiver, or both. And you’ll not get a value when you didn’t receive the packet. Lastly, it may be that the error is small, but it’s drifting too much during the packet.
It might be worth recording a max. deviation or latest deviation in the LocalStats, or just only printing it in the logs.
Currently plan is to add this value to the log as a debug message, and if it proves to be extremely useful, come back and possibly add to meshpacket.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Radiolib includes the lora.getFrequencyError() function to return the offset from expected frequency center. This can be added to meshpacket and used to help debug mesh problems.