Adding ADA4026 Soil Moisture Sensor#825
Open
rpnahm wants to merge 2 commits intomeshtastic:masterfrom
Open
Conversation
Member
|
Thanks @rpnahm ! Please go ahead and create the PR, we often look at these in parallel |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I added ADA4026 to the TelemetrySensorType enum so that I can add support for the sensor in the meshtastic/firmware repo.
Should I wait to create a pr for the sensor.cpp and .h files within the meshtastic/firmware repo until these changes get merged?
Checklist before merging