Remove deprecated meshtastic/js dependency #638
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the deprecated meshtastic/js dependency and updates the code to use meshtastic/transport-web-bluetooth along with updated core module imports. Key changes include:
- Updating import paths in PacketToMessageDTO.ts to use "@meshtastic/core" and revised message store locations.
- Changing the dependency in MessageItem.tsx from meshtastic/js to meshtastic/core.
- Refactoring BLE.tsx to use TransportWebBluetooth and MeshDevice, including updating the Bluetooth service filter.
- Removing the meshtastic/js dependency from package.json.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/core/dto/PacketToMessageDTO.ts | Updated imports for core types and message store files to reflect new dependency |
| src/components/PageComponents/Messages/MessageItem.tsx | Updated dependency imports from meshtastic/js to meshtastic/core |
| src/components/PageComponents/Connect/BLE.tsx | Refactored BLE connection to use TransportWebBluetooth and MeshDevice, with updated service filter |
| package.json | Removed meshtastic/js dependency and retained transport dependencies |
Collaborator
|
@philon- Wanted to see if we can make this PR active so we can get it merged? |
tjpaulsondev
pushed a commit
to tjpaulsondev/web
that referenced
this pull request
Jun 12, 2025
* Remove deprecated meshtastic/js dependency * Bump dependency version * Fix linting --------- Co-authored-by: philon- <philon-@users.noreply.github.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the dependence on the old, deprecated package meshtastic/js and uses meshtastic/transport-web-bluetooth instead.
Note: This PR in meshtastic/js needs to be merged before this PR can be merged.
Related Issues
This PR in meshtastic/js
Changes Made
Testing Done
Tested using Chrome with an esp32 device.
Checklist