Merged
Conversation
8f44fdd to
0018307
Compare
yushangdi
reviewed
Jan 28, 2026
src/lib.rs
Outdated
| let filename_str = filename.to_string_lossy().to_string(); | ||
|
|
||
| // Track artifact for vLLM summary | ||
| let artifact_name = filename |
Contributor
There was a problem hiding this comment.
maybe I'm missing something. why this code will only run vllm artifacts? do we need to check vllm file prefix and only add vllm artifacts to vllm_state?
Contributor
Author
There was a problem hiding this comment.
updated! I removed most of that logic since it was unnecessary, and moved the rest into the vllm_state.add_artifact function
0018307 to
2ae9ed8
Compare
yushangdi
reviewed
Jan 29, 2026
|
|
||
| // If vLLM artifacts are present, use vLLM summary as index.html and save | ||
| // traditional tlparse index as tlparse_index.html for reference | ||
| if vllm_state.has_artifacts() { |
Contributor
There was a problem hiding this comment.
since this override the normal html, can we add a more detailed description of when would vllm_state.has_artifacts() = True? e.g. it's true when there exist at least a file that starts with vllm
Contributor
Author
There was a problem hiding this comment.
updated the comment!
e540338 to
5e8cc04
Compare
yushangdi
approved these changes
Jan 29, 2026
5e8cc04 to
a64185d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a dedicated vllm-compile tlparse viewer which looks like (internal example):

When we encouter vllm compilation artifacts (prefixed with
vllm_), we use the vllm parsers located undersrc/vllm. We will also choose to display a differentindex.html.In vllm, we will have multiple layers of compilation. First based on dynamic shapes (shape ranges, and then specialized sizes), and then if using piecewise cudagraphs then it will compile subgraphs of the toplevel model. So we want to have a hierarchical view like
To do this, we create a
VllmStateto pass around which tracks the artifacts as we parse through. In the vllm logs added in vllm-project/vllm#33213, vllm will emit avllm_piecewise_compile_startlog at the start of each subgraph compilation, containing the submod name and compile range/size. As we parse subsequent inductor artifacts (post_grad_graph, output_code, etc.), we attach them to the current subgraph inVllmState. When we encounter the nextvllm_piecewise_compile_start, we know the previous subgraph is complete and start collecting artifacts for the new one.