Transform Configurations to Spring Repository #226
Open
Transform Configurations to Spring Repository #226
Conversation
| @@ -0,0 +1,133 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| @@ -0,0 +1,26 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| @@ -0,0 +1,12 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
Comment on lines
+145
to
+149
| Optional<Component> components = Optional.ofNullable( | ||
| DataAccessUtils.singleResult(namedParameterJdbcTemplate.query( | ||
| getByNameAndVersion, | ||
| sqlParameterSource, | ||
| new ComponentExtractor()))); |
Collaborator
There was a problem hiding this comment.
Why not return this? instead of line 150-157
| SqlParameterSource sqlParameterSource = new MapSqlParameterSource() | ||
| .addValue("id", componentKey.getId()) | ||
| .addValue("versionNumber", componentKey.getVersionNumber()); | ||
| Optional<Component> components = Optional.ofNullable( |
Collaborator
There was a problem hiding this comment.
why not return this
| @@ -0,0 +1,44 @@ | |||
| package io.metadew.iesi.metadata.configuration.script; | |||
Collaborator
There was a problem hiding this comment.
Is this still needed? ScriptParameters should be extracted at ScriptExrtractor
|
|
||
| import io.metadew.iesi.metadata.definition.Metadata; | ||
| import io.metadew.iesi.metadata.definition.action.key.ActionKey; | ||
| import io.metadew.iesi.metadata.definition.component.ComponentParameter; |
Comment on lines
33
to
38
| public String ErrorExpectedGet() { | ||
| return errorExpected; | ||
| } | ||
| public String ErrorStopGet() { | ||
| return errorStop; | ||
| } |
Collaborator
There was a problem hiding this comment.
getter should already exist through Lombok Data
Comment on lines
17
to
16
| @Data | ||
| @Getter | ||
| @Setter |
Collaborator
There was a problem hiding this comment.
Why remove data and add getter/setter?
Comment on lines
45
to
47
| public String getName() { | ||
| return getMetadataKey().getName(); | ||
| } |
Collaborator
There was a problem hiding this comment.
Getter should exist
added 2 commits
November 5, 2020 12:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Is your feature request related to a problem? Please describe.
Transform the existing metadata configurations to repositories.
Id
b05e527