Fix gentoo bug 965835, cleanup/fix other issues#29
Open
ferringb wants to merge 4 commits intometajack:masterfrom
Open
Fix gentoo bug 965835, cleanup/fix other issues#29ferringb wants to merge 4 commits intometajack:masterfrom
ferringb wants to merge 4 commits intometajack:masterfrom
Conversation
Signed-off-by: Brian Harring <ferringb@gmail.com>
Signed-off-by: Brian Harring <ferringb@gmail.com>
Signed-off-by: Brian Harring <ferringb@gmail.com>
511f9a4 to
51c3f8c
Compare
Fixes * added boolean deleted and created fields per v3 spec. These indicate if it's a ref deletion, new ref created, etc. * fixed the exception for deletion events * forced data annotation via dataclass, thus documenting the event structure. I did this explicitly because there are no tests and I had to rework a lot of this, so might as well use a dataclass to ensure I didn't drop any event data. This is not runtime enforcement however. * fixed the comparison urls sent for a ref creation event. This is larger than intended, but the data validation I had to shove in to verify I didn't break anything. The result is simpler/cleaner however. Signed-off-by: Brian Harring <ferringb@gmail.com>
51c3f8c to
94e6ebc
Compare
Author
|
The above is shook out as much as I can do so, including with the followon PR's flexing it in different ways. please take a look. |
ferringb
added a commit
to ferringb/notify-webhook
that referenced
this pull request
Nov 11, 2025
Note: this actually fails on the first commit in history; diff-tree is against the parent. It's edge case, but it exists. This is a seperated PR from metajack#29 for review reasons. When this and that lands, issue metajack#28 can be closed. Signed-off-by: Brian Harring <ferringb@gmail.com>
ferringb
added a commit
to ferringb/notify-webhook
that referenced
this pull request
Nov 12, 2025
Note: this actually fails on the first commit in history; diff-tree is against the parent. It's edge case, but it exists. This is a seperated PR from metajack#29 for review reasons. When this and that lands, issue metajack#28 can be closed. Signed-off-by: Brian Harring <ferringb@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So... I wasn't much willing to reconfigure my IDE to not reformat, so the first commit is a ruff reformat of the repo.
There are two main commits here:
pdb.set_trace(). I also flipped on pretty print for any json dumping.Specifically, that's this: