Inclusion of a more extensive set of SEL methods. #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added Hgamma line to list, extinction coefficients * Created "--bluedust" flag to calculate E(B-V) from Hb/Hg. * Created metscales.calcEB_Vblue() to do E(B-V) calculation. * Added dust_blue(=False) flag to metallicity.calculation(), metallicity.run()
…7, MNRAS, 465, 1384).
*Fixed bug: C17 O3N2 ratio defined differently than M08. *Fixed bug: C17 was looking at roots over too broad a metallicity. *Moved C17 O3Hb method into standard set.
* Fixed bug in M08_O3N2 calculation: np.log() --> np.log10().
* Changed B07 --> B07_N2Ha * Allowed KK04_N2Ha to be called on its own.
- Changed M13_N2 --> M13_N2Ha. - Calculate N2/O2 from (N2/Ha)*(2.86*Hb/O2).
Author
|
I should add that I was finally convinced to create this pull request because I was thinking of including the R-hat indicator of Laseter et al. 2024. https://www.aanda.org/articles/aa/pdf/2024/01/aa47133-23.pdf |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This probably should have been done in several stages, as there are a few additions.
New metallicity scales
I've included several new metallicity scales based on strong line indicators. The SEL scales added are:
calcPMC09]calcB07]calcD16]calcC17]calcPG16]Extinction from blue lines
I've also implemented the option
bluedustto use the ratio of H-gamma / H-beta as an extinction indicator. This may be specific to my work, and could be removed. This required addingHgas a line and a newE(B-V)bluemethod.Input file read flexbiility
I modified the header reading functionality in
readfileto allow for slightly non-standard headers (tab separated instead of comma).Some formatting adjustments
There are a number of places where the changes seem only to be removal of spaces at the end of lines. Not sure how these crept in.